blob/s3blob: fix third-party S3 compatible buckets when checksum calculation is when_required - #3765
blob/s3blob: fix third-party S3 compatible buckets when checksum calculation is when_required#3765tgummerer wants to merge 1 commit into
Conversation
…en_required In google#3736, the ChecksumSHA256 was unconditionally set to `UNSIGNED-PAYLOAD`, when the checksum calculation is set to `when_required`. This works for S3, but doesn't work for all third party S3 compatible bucket implementations, e.g. Cloudflare R2 (see pulumi/pulumi#24219). Instead, make sure we thread the RequestChecksumCalculation from the buckets settings through, which to the best of my understanding should fix this issue.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3765 +/- ##
==========================================
+ Coverage 75.40% 75.43% +0.02%
==========================================
Files 104 104
Lines 14263 14262 -1
==========================================
+ Hits 10755 10758 +3
+ Misses 2770 2767 -3
+ Partials 738 737 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
TBH I don't fully understand what's going on here so I'm a bit concerned to regress again. I copied your change over to #3766 and added a test, can you review the ".replay" files and make sure they look right? |
2 participants
In #3736, the ChecksumSHA256 was unconditionally set to
UNSIGNED-PAYLOAD, when the checksum calculation is set towhen_required. This works for S3, but doesn't work for all third party S3 compatible bucket implementations, e.g. Cloudflare R2 (see pulumi/pulumi#24219).Instead, make sure we thread the RequestChecksumCalculation from the buckets settings through, which to the best of my understanding should fix this issue.