Fix TSAN flakes and data races in msgqueue syscall tests - #13857
Merged
Conversation
copybara-service
Bot
force-pushed
the
test/cl954724776
branch
4 times, most recently
from
July 28, 2026 21:14
6b272cc to
ebd5406
Compare
In test/syscalls/linux/msgqueue.cc: - Fixed a TSAN data race in MsgSndRmWhileBlocking and MsgRcvRmWhileBlocking by passing the message queue ID by-value into background threads instead of evaluating queue.get() on the raw shared pointer. - Fixed a multi-run global state bleed in MsgCtlMsgInfo by checking global msgpool queue offsets relative to their existing background state rather than hardcoding strict zeros. PiperOrigin-RevId: 955474605
copybara-service
Bot
force-pushed
the
test/cl954724776
branch
from
July 28, 2026 21:33
ebd5406 to
177c633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TSAN flakes and data races in msgqueue syscall tests
In test/syscalls/linux/msgqueue.cc:
passing the message queue ID by-value into background threads instead of
evaluating queue.get() on the raw shared pointer.
msgpool queue offsets relative to their existing background state rather than
hardcoding strict zeros.