Fix flakiness in cgroup2 tests - #13876
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
Replaced explicit absl::SleepFor(absl::Milliseconds(15)) with a while loop that waits for memory accounting to settle before breaking, capping the wait at a generous 10 seconds. This avoids flaky test failures (in targets like cgroup2_test_runsc_kvm_save) caused when the sentry's internal 10ms memory stats scan executes slowly under load, KVMSave overhead, or thread starvation. PiperOrigin-RevId: 954980469
copybara-service
Bot
force-pushed
the
test/cl954980469
branch
from
July 28, 2026 03:20
3e8605f to
e8ee9b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flakiness in cgroup2 tests
Replaced explicit absl::SleepFor(absl::Milliseconds(15)) with a while loop
that waits for memory accounting to settle before breaking, capping the wait
at a generous 10 seconds. This avoids flaky test failures (in targets like
cgroup2_test_runsc_kvm_save) caused when the sentry's internal 10ms memory
stats scan executes slowly under load, KVMSave overhead, or thread starvation.