Remove Singleton from CharacterFormManager#1514
Open
yukawa wants to merge 1 commit into
Open
Conversation
yukawa
force-pushed
the
remove_singleton_from_character_form_manager
branch
from
33f6b2c to
aa162cb
Compare
yukawa
changed the title
Singleton with absl::NoDestructorSingleton from CharacterFormManager
As part of our ongoing efforts to remove the dependency on Singleton, this commit rewrites config/character_form_manager.cc with absl::NoDestructor rather than Singleton.
yukawa
force-pushed
the
remove_singleton_from_character_form_manager
branch
from
aa162cb to
f4b14e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of our ongoing efforts to remove the dependency on
Singleton, this commit rewritesconfig/character_form_manager.ccwithabsl::NoDestructorrather thanSingleton.Issue IDs
N/A
Steps to test new behaviors (if any)