fix: give alternate unit suffixes their own keys - #1314
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Units whose UNECE symbol column lists aliases (e.g. "% or pct") were emitted twice under the SAME Python name, so the second assignment overwrote the first. units.PERCENT therefore resolved to the "pct" descriptor and the "%" one was unreachable as a module attribute. The same collision affected KILOGRAM_PER_LITRE, DECITONNE and RACK_UNIT. units_from_xls.py now keeps the canonical key for the first suffix and derives a distinct key for each alternate suffix; units.py is updated to match. Adds test/util/units_test.py covering the primary suffix, the distinct alias keys, and lookup by every suffix. Fixes google#1250
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1250
When a UNECE symbol column lists aliases (
% or pct), the generator emitted both descriptors under the same Python key, so the second overwrote the first —units.PERCENTresolved topctand the%descriptor was unreachable as a module attribute.KILOGRAM_PER_LITRE,DECITONNEandRACK_UNIThad the same collision.units_from_xls.pynow keeps the canonical key for the first suffix and derives a distinct key for each alternate (PERCENT_PCT, etc.);units.pyis regenerated to match. Lookup viaunits.Unit('%')/units.Unit('pct')is unchanged. Newtest/util/units_test.pyfails on master and passes with the fix.