fix(derive-bits): support zero-length results#321
Open
harrshita123 wants to merge 1 commit into
Open
Conversation
96b0a08 to
2043b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
length == 0while continuing to reject negative lengthsWhy
The browser implementation already returns an empty
Uint8Listfor zero-bit ECDH and PBKDF2 derivations, as defined by the Web Cryptography algorithms. The FFI implementation instead rejected the same calls, makingpackage:webcryptobehavior platform-dependent.For ECDH, the implementation already had an empty-result branch, but its preceding
length <= 0check made that branch unreachable. For PBKDF2, an explicit zero-length guard contradicted the algorithm's empty-result step. The replacement return follows the specification's validation order and avoids a zero-sized native allocation and isolate dispatch.This change aligns the native backend with the browser backend and keeps negative-length validation intact.
Fixes #320.
Validation
dart format --output none --set-exit-if-changed ...dart analyze --fatal-warnings .dart test test/webcrypto_test.dart -p vm(1,441 tests)dart test test/webcrypto_test.dart -p chrome -c dart2jsdart test test/webcrypto_test.dart -p chrome -c dart2wasm