Support forwarding of channels and channel arrays in impl-style procs.#4230
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_912646666
branch
2 times, most recently
from
c7d438a to
eac15cb
Compare
Previously if a proc A constructor would spawn proc B, forwarding one of the channels passed in to the A constructor, then IR conversion would fail. This was because it would only correctly handle the subset of constructor params that were retained as members of the A instance. PiperOrigin-RevId: 913770352
copybara-service
Bot
force-pushed
the
test_912646666
branch
from
eac15cb to
175c391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support forwarding of channels and channel arrays in impl-style procs.
Previously if a proc A constructor would spawn proc B, forwarding one of the channels passed in to the A constructor, then IR conversion would fail. This was because it would only correctly handle the subset of constructor params that were retained as members of the A instance.