Conversation
This allows developers to isolate their development from their use of `cargo hermes verify` globally. It also makes development slightly easier to integrate with Docker, as `cargo run setup`, when run in the container, doesn't try to write to paths that aren't writeable (this is specifically a problem since we re-define the UID of the user in the container in order to match the external UID, making them not root in the container, but thus making them not have write permissions to root's home directory). gherrit-pr-id: Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gzjx2m23qp7ycaxvr2hvvsspjslbysoix #3214 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6067 6067
==================================================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gherrit-pr-id: G4iagi5qpsy4s5zjljqjzg5p5svspugc3
174688c to
db3bbf9
Compare
da78819 to
fc31802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G4iagi5qpsy4s5zjljqjzg5p5svspugc3 && git checkout -b pr-G4iagi5qpsy4s5zjljqjzg5p5svspugc3 FETCH_HEADCheckout
git fetch origin refs/heads/G4iagi5qpsy4s5zjljqjzg5p5svspugc3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G4iagi5qpsy4s5zjljqjzg5p5svspugc3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.