feat(storage): add resource span attributes for ACO ( App Centric Observability )#16119
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a private helper method EnrichSpan to populate OpenTelemetry span attributes (gcp.resource.destination.id and gcp.resource.destination.location) using bucket metadata upon successful bucket operations (such as creation, retrieval, updates, and locking). It also adds corresponding unit tests to verify these attributes. The review comments suggest making EnrichSpan static since it does not access member variables, and checking for an uninitialized project number (value 0) to avoid generating invalid resource IDs.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16119 +/- ##
========================================
Coverage 92.27% 92.28%
========================================
Files 2218 2221 +3
Lines 206654 207186 +532
========================================
+ Hits 190699 191203 +504
- Misses 15955 15983 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b9d9575 to
53127d4
Compare
c978382 to
ab9f016
Compare
| TracingConnection::TracingConnection(std::shared_ptr<StorageConnection> impl) | ||
| : impl_(std::move(impl)) {} | ||
| : impl_(std::move(impl)), | ||
| background_threads_( |
There was a problem hiding this comment.
This appears to always create an instance of BackgroundThreads. If the user has set the GrpcBackgroundThreadsFactoryOption they would expect the value of that Option to be used without creating another BackgroundThreads internally.
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
@scotthart I've addressed review comments. Can you please take another look at it? |
4 participants
No description provided.