Skip to content

impl(bigtable): disable unrelated log messages in TableApplyWithLogging test#16258

Open
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:bigtable_table_logging_flake
Open

impl(bigtable): disable unrelated log messages in TableApplyWithLogging test#16258
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:bigtable_table_logging_flake

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart scotthart requested a review from a team as a code owner July 14, 2026 20:37
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a test helper lambda in 'data_integration_test.cc' to disable metrics and avoid log pollution, which changes the 'options' parameter to be passed by value. The reviewer correctly points out that 'options' should be moved using 'std::move' when calling 'MakeDataConnection' to prevent an unnecessary copy of the 'Options' object, adhering to the repository's optimization guidelines.

Comment thread google/cloud/bigtable/tests/data_integration_test.cc Outdated
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (e493b2d) to head (129e375).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16258      +/-   ##
==========================================
- Coverage   92.27%   92.27%   -0.01%     
==========================================
  Files        2214     2214              
  Lines      206505   206507       +2     
==========================================
- Hits       190556   190549       -7     
- Misses      15949    15958       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) July 14, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant