feat(storage): add checksum validation in the json read channel#13270
Draft
nidhiii-27 wants to merge 2 commits into
Draft
feat(storage): add checksum validation in the json read channel#13270nidhiii-27 wants to merge 2 commits into
nidhiii-27 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces CRC32C checksum validation for unbuffered downloads in ApiaryUnbufferedReadableByteChannel by integrating a Hasher and wrapping the content stream in a HashingInputStream during full object downloads. The reviewer feedback highlights three key improvements: using the instance field hasher instead of Hasher.defaultHasher() to respect custom hasher configurations, avoiding the overhead of wrapping the stream when the expected checksum is missing, and asserting the specific ChecksumMismatchException directly in the unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled default full object checksum validation for the following:
Storage#reader(blobId)Storage#reader(bucketName, blobName)