chore: add DEV workflow instructions for librarian#13277
Conversation
Adds instructions on: - How to find the Librarian on-call schedule and support contacts - Review and approval requirements for librarian.yaml changes - How to run Librarian locally to test changes to the generator or librarian.yaml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates sdk-platform-java/DEVELOPMENT.md to add documentation for the Client Library Generation tool, Librarian. It includes contact information, review requirements, prerequisites, and step-by-step instructions for running the generator with local changes. A review comment correctly identified a typo in the prerequisites section, suggesting to change 'JD17' to 'JDK 17'.
| Any changes to `librarian.yaml` (adding APIs, updating dependencies, changing configurations, etc.) **must** be reviewed and approved by the Librarian on-call team. Please include `cloud-sdk-librarian-oncall@google.com` or an on-call engineer as a reviewer on your PR. | ||
|
|
||
| #### Prerequisite | ||
| Make sure you have Go installed (as Librarian is written in Go), as well as Python, Maven, and JD17 (use https://sdkman.io/). |
There was a problem hiding this comment.
The abbreviation 'JD17' appears to be a typo for 'JDK 17'.
| Make sure you have Go installed (as Librarian is written in Go), as well as Python, Maven, and JD17 (use https://sdkman.io/). | |
| Make sure you have Go installed (as Librarian is written in Go), as well as Python, Maven, and JDK 17 (use https://sdkman.io/). |
|
|
1 participant
Fixes googleapis/librarian#5497
cc @JoeWang1127 @zhumin8, PTAL, not sure about all of these (tested the workflows locally though).