test(compute): simplify and re-enable flaky ITPaginationTest test case#13288
Open
whowes wants to merge 3 commits into
Open
test(compute): simplify and re-enable flaky ITPaginationTest test case#13288whowes wants to merge 3 commits into
whowes wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the testPaginationIterating integration test in ITPaginationTest.java by removing the @Ignore annotation and updating its assertion logic to verify that multiple pages are traversed. The reviewer recommends optimizing the test by breaking out of the iteration loop early once two elements are processed, which avoids making excessive synchronous API calls for all zones in the project.
whowes
force-pushed
the
whowes/issue-11759-flaky
branch
from
071fa09 to
096d74b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the test more reliable, the assertions are simplified to verify that all zone names are non-null and at least 2 pages have been traversed by the iterator.
This test case has been quite flaky historically (see past comment). Iterating occasionally short-circuits at different places through the list of zones (which Gemini hypothesizes may be aligned with regional boundaries), and the DEFAULT_ZONE used in the test's current final assertion appears towards the end of the alphabetically-sorted list.
Fixes #11759