fix(bigquery): prevent NullPointerException in OTel tracing when JobId is null#13301
Open
keshavdandeva wants to merge 3 commits into
Open
fix(bigquery): prevent NullPointerException in OTel tracing when JobId is null#13301keshavdandeva wants to merge 3 commits into
keshavdandeva wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds null checks for job IDs before retrieving OpenTelemetry attributes in BigQueryImpl.java. The reviewer recommended using Attributes.empty() instead of passing null to setAllAttributes to prevent potential NullPointerExceptions in certain OpenTelemetry implementations or mock tracers.
lqiu96
approved these changes
May 29, 2026
Member
|
Thanks for the info and the context. I don't have any concerns with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/517929704
This PR addresses a
NullPointerExceptionthat occurs in the BigQuery client library when OpenTelemetry tracing is enabled and operations are performed on jobs that do not have a client-assignedJobIdat the start of the call.A notable case where this happens is during dry-run queries (often used to determine statement type or fetch statistics) where
JobInfo.getJobId()returns null. The OTel instrumentation was attempting to extract attributes from theJobIdwithout checking for nullability.Changes:
JobId.getOtelAttributes()inBigQueryImpl.create(JobInfo)(line 455).JobId.getOtelAttributes()inBigQueryImpl.getQueryResults(JobId)(line 2128).BigQueryImpl.queryWithTimeout(line 2075).