feat(google/logging/v2): onboard a new library#8863
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/logging-api package, which contains auto-generated clients, samples, and proto definitions for the Cloud Logging API (including Config, Logging, and Metrics services). The review feedback highlights two issues: first, the auto-generated links in the README point to the wrong package directory and should be corrected upstream in the generator templates; second, the webpack configuration should be updated to use a more generic library name and filename, as the package exports multiple services rather than just ConfigServiceV2.
quirogas
force-pushed
the
feat/onboard-logging-api
branch
2 times, most recently
from
July 20, 2026 18:27
2be3e15 to
9be6a9b
Compare
quirogas
force-pushed
the
feat/onboard-logging-api
branch
from
July 20, 2026 18:36
9be6a9b to
93e9cd5
Compare
quirogas
marked this pull request as ready for review
July 20, 2026 18:58
feywind
reviewed
Jul 20, 2026
quirogas
force-pushed
the
feat/onboard-logging-api
branch
from
July 20, 2026 20:14
93e9cd5 to
5fb8c11
Compare
feywind
approved these changes
Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.