Skip to content

feat(Gax): configure InsecureCredentialsWrapper when hasEmulator is true #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bshaffer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(Gax): configure InsecureCredentialsWrapper when hasEmulator is true #9458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gax/src/GapicClientTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ private function setClientOptions(array $options)
$options['apiKey'],
$options['credentialsConfig']['quotaProject'] ?? null
);
} elseif ($hasEmulator && !isset($options['credentials'])) {
$this->credentialsWrapper = new InsecureCredentialsWrapper();
} else {
$enableRegionalAccessBoundary = filter_var(
getenv('GOOGLE_AUTH_TRUST_BOUNDARY_ENABLE_EXPERIMENT'),
Expand Down
5 changes: 5 additions & 0 deletions Gax/tests/Unit/GapicClientTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,6 +1861,7 @@ public function testHasEmulatorOption()
use GapicClientTrait {
buildClientOptions as public;
setClientOptions as public;
getCredentialsWrapper as public;
}
use ClientDefaultsTrait {
ClientDefaultsTrait::getClientDefaults insteadof GapicClientTrait;
Expand All @@ -1881,6 +1882,10 @@ private function createTransport(
$gapic->setClientOptions($options);

$this->assertTrue($gapic->hasEmulator);
$this->assertInstanceOf(
\Google\ApiCore\InsecureCredentialsWrapper::class,
$gapic->getCredentialsWrapper()
);
}

public function testGetServiceScopes()
Expand Down
Loading