Skip to content

Revert "chore: remove google-cloud-network-connectivity from state.yaml"#16118

Open
ohmayr wants to merge 1 commit intomainfrom
revert-16112-offload-network-connectivity-from-librarian
Open

Revert "chore: remove google-cloud-network-connectivity from state.yaml"#16118
ohmayr wants to merge 1 commit intomainfrom
revert-16112-offload-network-connectivity-from-librarian

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Mar 18, 2026

Given that the changes in cl/882798624 to fix the namespace for this library are in, we can onboard this to librarian again.

@ohmayr ohmayr requested review from a team as code owners March 18, 2026 00:26
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a prior change, re-integrating the google-cloud-network-connectivity library into the automated management system. This action follows the successful resolution of a namespace issue that previously necessitated its removal, ensuring the library can now benefit from automated updates and configuration.

Highlights

  • Re-onboarding google-cloud-network-connectivity: The google-cloud-network-connectivity library has been re-added to the .librarian/state.yaml configuration, allowing it to be managed by the librarian tool once more.
  • Resolution of prior issue: This re-onboarding is possible because a previous issue related to the library's namespace (fixed in cl/882798624) has been resolved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change, re-adding the configuration for google-cloud-network-connectivity to the .librarian/state.yaml file. This is intended to re-onboard the library to the librarian tool. The added configuration block is correctly placed in alphabetical order and its structure appears correct. I have no concerns with this change.

Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants