Skip to content

Feat: async driver for sqlalchemy-spanner#16122

Open
giulia-dt wants to merge 5 commits intogoogleapis:mainfrom
giulia-dt:main
Open

Feat: async driver for sqlalchemy-spanner#16122
giulia-dt wants to merge 5 commits intogoogleapis:mainfrom
giulia-dt:main

Conversation

@giulia-dt
Copy link

@giulia-dt giulia-dt commented Mar 18, 2026

This PR proposes an async implementation of the sqlalchemy driver for Spanner. This change allows Spanner to be used as a session database for ADK version >= 1.19.0.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #15687 🦕

@giulia-dt giulia-dt requested review from a team as code owners March 18, 2026 09:21
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces asynchronous capabilities to the SQLAlchemy Spanner driver. By providing an async implementation, it allows the Spanner dialect to be used effectively with applications requiring non-blocking I/O, such as those built with ADK version 1.19.0 or newer. This enhancement significantly improves the driver's performance and responsiveness in concurrent environments.

Highlights

  • Asynchronous Driver Implementation: A new asynchronous driver for sqlalchemy-spanner has been implemented, enabling non-blocking database operations.
  • New Dialect Registration: The new asynchronous dialect, spanner+spanner_asyncio, has been registered, allowing users to specify async connections.
  • Documentation Update: The README.rst file has been updated to include a new section on async support, providing usage instructions and an example.
  • Unit Tests for Async Functionality: Dedicated unit tests have been added to validate the creation of async engines and the behavior of async connections.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces asynchronous support for the SQLAlchemy Spanner driver, which is a great addition. The implementation correctly follows the standard SQLAlchemy pattern for async drivers by wrapping the synchronous DBAPI. The new documentation and unit tests are also well-implemented. I have a couple of minor suggestions to improve code clarity and documentation.

giulia-dt and others added 2 commits March 18, 2026 10:47
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do you support Spanner Async Client?

1 participant