Skip to content

feat(firestore): support array functions#16128

Draft
Linchin wants to merge 4 commits intogoogleapis:mainfrom
Linchin:fs-array
Draft

feat(firestore): support array functions#16128
Linchin wants to merge 4 commits intogoogleapis:mainfrom
Linchin:fs-array

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Mar 18, 2026

Supports the following:

  • array_first
  • array_last
  • array_first_n
  • array_last_n
  • array_maximum
  • array_maximum_n
  • array_minimum
  • array_minimum_n
  • array_slice (need to double check docstring)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firestore client library by integrating new array manipulation functions directly into pipeline expressions. This provides developers with more powerful and convenient ways to query and transform data within array fields, improving data processing capabilities without requiring client-side array handling.

Highlights

  • New Array Functions: Introduced array_first, array_last, array_first_n, and array_last_n to the Firestore pipeline expressions, allowing users to extract specific elements or sub-arrays from array fields.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for array_first, array_last, array_first_n, and array_last_n functions in Firestore pipelines. The implementation and system tests look good. However, I found issues in the unit tests for array_first_n and array_last_n where the parameter order is asserted incorrectly, leading to internally inconsistent tests. I've provided suggestions to fix these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant