fix(crc32c): Drop support for Python 3.8 and 3.9#16955
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request drops support for Python versions below 3.10, updating the README, Noxfile, pyproject.toml, and setup.cfg accordingly. A review comment identifies that Python 3.13 and 3.14 are missing from the classifiers in setup.cfg, which should be added to ensure consistency with the documentation and test matrix.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/google-crc32c/setup.cfg (32-33)
The classifiers section in setup.cfg is missing entries for Python 3.13 and 3.14. Since these versions are explicitly listed as supported in the README.md and are included in the noxfile.py test matrix, they should be added to the metadata to ensure consistency and to correctly signal support on PyPI.
parthea
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates `google-crc32c` to establish Python 3.10 as the minimum supported version, dropping support for Python 3.7, 3.8, and 3.9.
Changes
Note: Verification tests were skipped locally due to environment issues with building the C library in the Docker container, but changes are strictly metadata and configuration!
Fixes internal issue: http://b/482126936 🦕