chore(spanner): use Into<BatchDml> as input argument#5701
Open
olavloite wants to merge 1 commit into
Open
Conversation
Use Into<BatchDml> as the input argument for execute_batch_update. This allows an application to pass in a collection of statements, instead of having to manually construct a BatchDml struct.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the execute_batch_update API by allowing it to accept any type that implements Into, such as a vector of SQL strings or a BatchDmlBuilder. New From implementations and comprehensive tests were added to BatchDml and ReadWriteTransaction to support this change. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5701 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 226 226
Lines 55405 55501 +96
=======================================
+ Hits 54236 54331 +95
- Misses 1169 1170 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Into as the input argument for execute_batch_update. This allows an application to pass in a collection of statements, instead of having to manually construct a BatchDml struct.