Skip to content

feat(storage): implement appendable upload background worker#6001

Merged
vsharonlynn merged 5 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_3_2
Jul 17, 2026
Merged

feat(storage): implement appendable upload background worker#6001
vsharonlynn merged 5 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_3_2

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

This PR comes after #5956.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the internal infrastructure for Appendable Object Write (Bidi Write) in Google Cloud Storage, including a Connector to handle the initial handshake and redirects, and a background Worker to manage the live gRPC stream and upload intents. The feedback highlights two key issues: first, preconditions (if_metageneration_match and if_metageneration_not_match) are lost when transitioning from WriteObjectSpec to AppendObjectSpec in the connector; second, the worker exits silently with Ok(()) if the server closes the stream unexpectedly while the client is idle, which should instead be treated as an error.

Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/worker.rs
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.06579% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.05%. Comparing base (53d123d) to head (5068b51).

Files with missing lines Patch % Lines
src/storage/src/storage/bidi_write/worker.rs 95.06% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6001      +/-   ##
==========================================
+ Coverage   97.04%   97.05%   +0.01%     
==========================================
  Files         253      254       +1     
  Lines       63682    63986     +304     
==========================================
+ Hits        61798    62103     +305     
+ Misses       1884     1883       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn force-pushed the appendable_upload_3_2 branch 3 times, most recently from c8257a2 to 392297e Compare July 14, 2026 08:45
@vsharonlynn
vsharonlynn marked this pull request as ready for review July 14, 2026 08:59
@vsharonlynn
vsharonlynn requested review from a team as code owners July 14, 2026 08:59
Comment thread src/storage/src/storage/bidi_write/worker.rs
Comment thread src/storage/src/storage/bidi_write/worker.rs Outdated
Comment thread src/storage/src/storage/bidi_write/worker.rs
@vsharonlynn
vsharonlynn requested a review from joshuatants July 16, 2026 10:33
@vsharonlynn
vsharonlynn requested a review from joshuatants July 17, 2026 03:04
@vsharonlynn
vsharonlynn force-pushed the appendable_upload_3_2 branch from 5f3583e to 5068b51 Compare July 17, 2026 04:05
@vsharonlynn

Copy link
Copy Markdown
Contributor Author

I'll merge this first to meet deadlines. Please feel free to leave feedback. I will incorporate them in a separate PR. Thank you.

@vsharonlynn
vsharonlynn merged commit 5ba8d71 into googleapis:main Jul 17, 2026
41 checks passed
@vsharonlynn
vsharonlynn deleted the appendable_upload_3_2 branch July 17, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants