feat(storage): implement appendable upload background worker#6001
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the internal infrastructure for Appendable Object Write (Bidi Write) in Google Cloud Storage, including a Connector to handle the initial handshake and redirects, and a background Worker to manage the live gRPC stream and upload intents. The feedback highlights two key issues: first, preconditions (if_metageneration_match and if_metageneration_not_match) are lost when transitioning from WriteObjectSpec to AppendObjectSpec in the connector; second, the worker exits silently with Ok(()) if the server closes the stream unexpectedly while the client is idle, which should instead be treated as an error.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6001 +/- ##
==========================================
+ Coverage 97.04% 97.05% +0.01%
==========================================
Files 253 254 +1
Lines 63682 63986 +304
==========================================
+ Hits 61798 62103 +305
+ Misses 1884 1883 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c8257a2 to
392297e
Compare
5f3583e to
5068b51
Compare
|
I'll merge this first to meet deadlines. Please feel free to leave feedback. I will incorporate them in a separate PR. Thank you. |
This PR comes after #5956.