This repository was archived by the owner on Mar 31, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 172
feat(experimental): add AsyncAbstractObjectStream #1546
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
21e66a3
add AsyncAbstractObjectStream
chandra-siri 39503f4
keep _AsyncAbstractObjectStream private
chandra-siri 3c0fd66
Merge branch 'main' of github.com:googleapis/python-storage into bidi…
chandra-siri 0810afc
fix doc strings, add licence and type hints
chandra-siri a14bc68
pass abstract methods
chandra-siri 635ad07
add handle param
chandra-siri ba453d4
include handle in tests
chandra-siri 800c6df
remove unit tests for abstract class
chandra-siri 6dec6c6
bucket_name and object_name cannot be NONE
chandra-siri 2054989
minor edit - add bidi-stream in doc string
chandra-siri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
google/cloud/storage/_experimental/asyncio/async_abstract_object_stream.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import abc | ||
| from typing import Any, Optional | ||
|
|
||
|
|
||
| class _AsyncAbstractObjectStream(abc.ABC): | ||
|
chandra-siri marked this conversation as resolved.
|
||
| """Abstract base class to represent gRPC bidi-stream for GCS ``Object``. | ||
|
|
||
| Concrete implementation of this class could be ``_AsyncReadObjectStream`` | ||
| or ``_AsyncWriteObjectStream``. | ||
|
|
||
| :type bucket_name: str | ||
| :param bucket_name: (Optional) The name of the bucket containing the object. | ||
|
|
||
| :type object_name: str | ||
| :param object_name: (Optional) The name of the object. | ||
|
|
||
|
chandra-siri marked this conversation as resolved.
|
||
| :type generation_number: int | ||
| :param generation_number: (Optional) If present, selects a specific revision of | ||
| this object. | ||
|
|
||
| :type handle: bytes | ||
| :param handle: (Optional) The handle for the object, could be read_handle or | ||
| write_handle, based on how the stream is used. | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| bucket_name: str, | ||
| object_name: str, | ||
| generation_number: Optional[int] = None, | ||
| handle: Optional[bytes] = None, | ||
| ) -> None: | ||
| super().__init__() | ||
|
chandra-siri marked this conversation as resolved.
|
||
| self.bucket_name: str = bucket_name | ||
| self.object_name: str = object_name | ||
| self.generation_number: Optional[int] = generation_number | ||
| self.handle: Optional[bytes] = handle | ||
|
|
||
| @abc.abstractmethod | ||
| async def open(self) -> None: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def close(self) -> None: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def send(self, protobuf: Any) -> None: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def recv(self) -> Any: | ||
| pass | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.