This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat(zb-experimental): Add support for closing MRD#1554
Merged
Conversation
this will be the parent class for AsyncReadObjectStream and AsyncWriteObjectStream
…_reads_1_abs_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…python-storage into bidi_reads_4_read_obj_stream
…python-storage into bidi_reads_6_read_obj_stream
product-auto-label
Bot
added
size: m
Pulkit0110
suggested changes
Sep 30, 2025
Pulkit0110
previously approved these changes
Sep 30, 2025
Pulkit0110
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_stream_openand check it's value before doing any of the following operation.open,close,send,recvsocket_like_rpcinside open, so that it is a new object every time we open.initial_requestwould be None because close sets it to None.