Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: don't mix checksums - user provided & GCS #1560

Closed
chandra-siri wants to merge 1 commit into from
Closed

fix: don't mix checksums - user provided & GCS #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions google/cloud/storage/blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def __init__(
self._properties["generation"] = generation

if crc32c_checksum is not None:
self._properties["crc32c"] = crc32c_checksum
self._properties["user_provided_crc32c"] = crc32c_checksum

@property
def bucket(self):
Expand Down Expand Up @@ -2016,8 +2016,8 @@ def _do_multipart_upload(
info = self._get_upload_arguments(client, content_type, command=command)
headers, object_metadata, content_type = info

if "crc32c" in self._properties:
object_metadata["crc32c"] = self._properties["crc32c"]
if "user_provided_crc32c" in self._properties:
object_metadata["crc32c"] = self._properties["user_provided_crc32c"]

hostname = _get_host_name(client._connection)
base_url = _MULTIPART_URL_TEMPLATE.format(
Expand Down Expand Up @@ -2214,8 +2214,8 @@ def _initiate_resumable_upload(
if extra_headers is not None:
headers.update(extra_headers)

if "crc32c" in self._properties:
object_metadata["crc32c"] = self._properties["crc32c"]
if "user_provided_crc32c" in self._properties:
object_metadata["crc32c"] = self._properties["user_provided_crc32c"]

hostname = _get_host_name(client._connection)
base_url = _RESUMABLE_URL_TEMPLATE.format(
Expand Down