Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore(librarian): onboard to librarian#1625

Merged
parthea merged 6 commits into
mainfrom
onboard-to-librarian
Nov 19, 2025
Merged

chore(librarian): onboard to librarian#1625
parthea merged 6 commits into
mainfrom
onboard-to-librarian

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Nov 19, 2025

@parthea parthea requested a review from a team as a code owner November 19, 2025 00:48
@parthea parthea requested review from a team and gericdong November 19, 2025 00:48
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Nov 19, 2025
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 19, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the google-cloud-storage library with the librarian code generation system. The changes involve restructuring build-related files, consolidating project metadata, and updating version numbers to facilitate automated generation and maintenance. This move aims to streamline the development workflow and ensure consistency across generated components.

Highlights

  • Librarian Onboarding: The project is being onboarded to the librarian code generation system, centralizing configuration and build processes.
  • Configuration Relocation: Key configuration files such as noxfile.py and setup.py have been moved into a new .librarian/generator-input directory to align with the librarian structure.
  • Build Process Streamlining: The owlbot.py script (now .librarian/generator-input/librarian.py) has been simplified, removing specific environment variable exports and using broader glob patterns for file exclusions.
  • Version Updates: The library version has been consistently updated to 3.6.0 across relevant metadata and version files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request onboards the python-storage library to the librarian tool. This involves adding new configuration files under the .librarian directory, such as .repo-metadata.json, librarian.py (renamed from owlbot.py), noxfile.py, setup.py, and state.yaml. The changes also include updating version numbers and CI configurations. My review focuses on the correctness of these new configuration files. I've found a couple of potential issues in setup.py and state.yaml that could affect CI and the build process.

Comment thread .librarian/generator-input/setup.py
Comment thread .librarian/state.yaml Outdated
@parthea parthea added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 19, 2025
Comment thread .librarian/state.yaml Outdated
@parthea parthea enabled auto-merge (squash) November 19, 2025 01:14
@parthea parthea merged commit 361235a into main Nov 19, 2025
15 checks passed
@parthea parthea deleted the onboard-to-librarian branch November 19, 2025 01:22
chandra-siri added a commit that referenced this pull request Nov 19, 2025
parthea added a commit that referenced this pull request Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants