feat(common): add custom predicate matching to RetryPolicy#59
Merged
viacheslav-rostovtsev merged 3 commits intoJul 6, 2026
Conversation
quartzmo
requested changes
Jun 23, 2026
f09a863 to
ce54b74
Compare
quartzmo
approved these changes
Jun 25, 2026
aandreassa
reviewed
Jul 1, 2026
aandreassa
approved these changes
Jul 1, 2026
f1dadfd to
c3732f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(common): add custom predicate matching to RetryPolicy
For Scotty we'll need to retry on non-HTTP/GRPC errors, e.g. on low-level socket timeout error. This seemed generic enough (and present in other languages e.g. python) to add to a RetryPolicy.
Adds a
retry_predicate:keyword argument toGapic::Common::RetryPolicyto support matching retry errors against a custom callable predicate.Behavior
When a predicate is specified:
nil, the decision on whether to retry is made on the basis ofretry_codes.Intentional Scope
Support for
retry_predicate:was intentionally omitted fromGapic::CallOptions::RetryPolicyandGapic::Operation::RetryPolicy.We can add it there if needed. Scotty code will use the
Gapic::Common::RetryPolicycode.