Skip to content

feat: Ruby 3.2 minimum and Ruby 4.0 support#397

Open
aandreassa wants to merge 2 commits into
mainfrom
ruby32-4
Open

feat: Ruby 3.2 minimum and Ruby 4.0 support#397
aandreassa wants to merge 2 commits into
mainfrom
ruby32-4

Conversation

@aandreassa

@aandreassa aandreassa commented Jul 7, 2026

Copy link
Copy Markdown

chore(ci): pin action versions and resolve zizmor security warnings

Used go/github-zizmor-help?polyglot=github-com#local-scans-run-zizmor-on-your-cloudtop

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required Ruby version from 3.1 to 3.2 in both the README documentation and the gemspec file. Additionally, it bumps the google-style development dependency version to ~> 1.32.0. There are no review comments, and I have no feedback to provide.

Used go/github-zizmor-help?polyglot=github-com#local-scans-run-zizmor-on-your-cloudtop
@aandreassa aandreassa marked this pull request as ready for review July 9, 2026 03:24
@aandreassa aandreassa requested review from a team, olavloite and sakthivelmanii as code owners July 9, 2026 03:24
@aandreassa

Copy link
Copy Markdown
Author

@olavloite if you could please help me take a look!

  1. Removing v3.1 as it reached EOL over a year ago.

  2. Zizmor fixes that will coming down the pipeline!

services:
emulator:
image: gcr.io/cloud-spanner-emulator/emulator:latest
image: gcr.io/cloud-spanner-emulator/emulator:1.5.50

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The latest version is 1.5.55. Can we pin to that version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants