feat: Migrate and modernize React basic map with marker - #1603
Open
willum070 wants to merge 6 commits into
Open
Conversation
Change-Id: I912f02dbeb3c0b5af018ce934b5ca6423ac1fedc
Change-Id: Id920215ca434b63cb32e808b8bb234e9249e9dc4
Change-Id: I31ac0152d90798742182cf15f4e7fd610558f126
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Change-Id: Id78905993db1844a45e08c3061ae70a0ae992bd7
Change-Id: Ic4d6705f0b11ce28b60ee4cd589bd56a1da6e9c3
Change-Id: I7e792cd72d5029171072e855588e550f242a29b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
rgm-basic-mapsample to the repository, migrating the foundational React map patterns and adding marker functionality for completeness. It serves as the baseline example for developers looking to integrate the Google Maps JavaScript API natively within a React application using the community-standard@vis.gl/react-google-mapslibrary.Key Changes
rgm-basic-mapfrom js-samples.maps_rgm_basic_map) to accurately reflect the new sample structure.gmp-map), as the@vis.glwrapper programmatically mounts a standard<div>that inherits from the root container.README.mdto establish best practices for React developers, explicitly covering:<APIProvider>for optimal script loading and React Context management.<Map defaultCenter={...}>.mapIdto enable Cloud-based styling and Advanced Markers.<AdvancedMarker>components instead of legacygoogle.maps.Markerclasses.Testing
npm run build).npm start) and correctly renders the map and Advanced Marker on the screen.