ci(ship-ci): reuse ci.yml via workflow_call instead of duplicating - #17
Open
mogul wants to merge 1 commit into
Open
ci(ship-ci): reuse ci.yml via workflow_call instead of duplicating#17mogul wants to merge 1 commit into
mogul wants to merge 1 commit into
Conversation
ship-ci.yml (PRs into main) and ci.yml (PRs into release/**) had an identical check job copy-pasted in both files, so they would drift over time. Add a workflow_call trigger to ci.yml and have ship-ci.yml call it with `uses: ./.github/workflows/ci.yml`, mirroring the core repo pattern. Behaviour is unchanged — both still run checkout + typecheck + non-blocking npm audit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #306.
ci.yml(PRs intorelease/**) andship-ci.yml(PRs intomain) carried an identical check job copy-pasted into both files — they'd inevitably drift (the npm-auditcontinue-on-errormismatch CodeRabbit flagged on #306 was exactly that class of bug). This mirrors the core repo's pattern (#779), whereship-cireusesciviaworkflow_call.Change
ci.yml: add aworkflow_call:trigger.ship-ci.yml: replace the duplicatedcheckjob withuses: ./.github/workflows/ci.yml.Behaviour is unchanged — both paths still run checkout → typecheck → non-blocking
npm audit. Net −20 lines.Self-test
This PR targets
main, soship-ci.ymlruns on it and exercises the newworkflow_callreuse end-to-end.🤖 Generated with Claude Code
Summary by CodeRabbit
Note: The target repository already incorporated the
workflow_callreuse pattern with additional refinements (ci.yml omits a standalonepull_requesttrigger to avoid duplicate runs; ship-ci.yml covers bothmainandrelease/**branches; the caller job is namedCI:to match org ruleset required contexts). This commit preserves the original authorship trail while the conflict resolution keeps the improved implementation.