fix: remove character entity references in rebuild:audio script command - #20
Open
mogul wants to merge 1 commit into
Open
fix: remove character entity references in rebuild:audio script command#20mogul wants to merge 1 commit into
mogul wants to merge 1 commit into
Conversation
Signed-off-by: Mike Shiner <mike.shiner00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a syntax error in the
rebuild:audionpm script insidepackage.json.Impact
I noticed that the pre-built release AppImage doesn't contain the correct audio build for Linux (CachyOS). It's likely that when this release was produced, the audio build wasn't recompiled from Windows due to the package.json command being borked.
I've been debugging since I downloaded the Linux release, I go to Plugins > Audio > '+ NAM' > Select NAM file, but nothing happens. It does not get updated in the UI. Running
npm run rebuild:audiofixes this, but only after this patch.Root Cause
The script command had an HTML-encoded
&&instead of&&. This caused the command to fail immediately when attempting to run a clean build of the audio engine: