docs: document the full-mix-vs-stems auto-switch in the Stem Mixer - #8
Open
topkoa wants to merge 2 commits into
Open
docs: document the full-mix-vs-stems auto-switch in the Stem Mixer#8topkoa wants to merge 2 commits into
topkoa wants to merge 2 commits into
Conversation
Verified against plugins/stems (computeMixGains in src/mix-gains.js): when a song carries its
pristine full mix, the mixer plays THAT — the original untouched audio, not a lossy recombination
of the separated stems — as long as every stem is on at 100% ("unity"). The moment any stem is
muted or lowered, it crosses to the separated stems so the change is audible, and stays there until
every stem is back at 100%.
Added a "Full Mix vs. Separated Stems" section to the mixer page explaining the switch and why it
exists (separation is lossy, so you only pay that quality cost when you actually want a custom
balance), and linked the Stem Splitter page's "untouched audio" note to it. Also added the Stem
Splitter cross-link to the mixer's Related Pages.
Signed-off-by: topkoa <topkoa@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated Stem Mixer documentation to explain full-mix and separated-stem playback behavior, clarified the Stem Splitter losslessness caveat, and added a related-page link. ChangesStem Mixer documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Explain WHY the full mix is there to play: the feedpak format reserves the `full` stem for the complete mixdown and recommends retaining it when a song is separated, and any in-app split keeps it. Links to the published spec section. Signed-off-by: topkoa <topkoa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Stem Splitter page. Two changes, both verified against the code.
The behavior (confirmed in
plugins/stems/src/mix-gains.js)computeMixGainsplays the song's pristine full mix — the original audio, not a recombination of the separated stems — whenever a full mix exists and every stem is on at 100% ("unity"). The instant any stem is muted or lowered, it crosses to the separated stems, and stays there until every stem is back at 100%.The point is quality: separation is lossy, so summing stems back isn't identical to the original. Playing the real full mix by default means you only pay that cost when you actually want a custom balance.
Docs
Builds clean under
mkdocs build --strict.Summary by CodeRabbit