Skip to content

fix(input_setup): keep backdrop-blur during calibration wizard #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OmikronApex wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(input_setup): keep backdrop-blur during calibration wizard #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions plugins/input_setup/screen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,20 +164,21 @@

host.querySelector('[data-is-cal]').addEventListener('click', () => {
if (hasDetector) {
// Hide our own full-screen overlay while note_detect's
// Calibration Wizard runs on top. That wizard goes
// transparent (pointer-events:none) when it minimizes to
// expose the Tuner; if our overlay stayed up it would show
// through — covering the tuner with the still-mounted
// "select your input" card and looking like a second
// wizard at the input step. Restore it on done/cancel
// (one of which always fires when that wizard closes).
// Hide only the inner card while note_detect's Calibration
// Wizard runs on top — keep the overlay element in the DOM
// so its backdrop-blur stays active. The wizard goes
// pointer-events:none when it minimizes to expose the Tuner;
// hiding just the card prevents the "select your input" panel
// from showing through without removing the background blur.
// Restore on done/cancel (one always fires when wizard closes).
const ov = document.getElementById('input-setup-overlay');
const prevDisplay = ov ? ov.style.display : '';
if (ov) ov.style.display = 'none';
const card = ov && ov.querySelector('[data-is-host]');
const prevDisplay = card ? card.style.display : '';
if (card) card.style.display = 'none';
const restore = () => {
const o = document.getElementById('input-setup-overlay');
if (o) o.style.display = prevDisplay;
const c = o && o.querySelector('[data-is-host]');
if (c) c.style.display = prevDisplay;
};
window.noteDetect.launchCalibration({
instrument: inst,
Expand Down
Loading