refactor(server): extract shop + inject get_progression_content into the seam (R3)

[byrongamatos]

The progression-content substrate, proven by its first consumer (shop).

_get_progression_content — a lazy, double-checked-locking content cache — is now published into the appstate seam as a callable. The cache global, its lock, and the function all stay in server.py (startup uses it, and test_progression_api patches server._progression_content directly), so zero test retargeting — routers just call appstate.get_progression_content().

Since the accessor is defined at server.py:1152 but the import-top configure() runs at :346, a second appstate.configure(get_progression_content=…) publishes it right after the def (configure is idempotent/additive).

First consumer: routers/shop.py (3 routes). Bodies verbatim. This unblocks stats / progression / profile next — they all share the accessor.

server.py: 7,880 → 7,845.

Verification

• Route table identical (143); pyflakes clean.
• pytest 2401 passed — including test_progression_api, whose server._progression_content patch still works because the cache stayed put.
• Boot smoke: GET /api/shop 200 (drives appstate.get_progression_content); buy 400 on bad body. npm run lint 0; Codex 0 findings.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added a cosmetics shop where players can view available items and their wallet balance.
  • Players can purchase cosmetics using Decibels, with validation for unavailable items, duplicate purchases, and insufficient funds.
  • Players can equip owned cosmetics in compatible slots or unequip them.
• Documentation
  • Updated the project’s line-count register and router coverage details.

[coderabbitai]

📝 Walkthrough

Walkthrough

The cosmetics shop endpoints moved from server.py into a dedicated router. appstate now accepts the progression-content accessor, and server.py configures and mounts the extracted router.

Changes

Cosmetics shop router extraction

Layer / File(s)	Summary
Progression content appstate seam lib/appstate.py, server.py	The progression-content accessor is added to the appstate injection slots and configured for router access.
Shop router behavior lib/routers/shop.py	The shop router implements listing, purchase, and equip endpoints with wallet, ownership, slot, and item validation.
Server router wiring server.py, docs/size-exemptions.md	The shop router is imported and mounted, inline shop handlers are removed, and the documented server metrics are updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• got-feedBack/feedBack#847: Refactors inline server.py API handlers into a dedicated router with updated wiring.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main refactor: extracting shop routes and exposing get_progression_content through the appstate seam.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/r3-progression-substrate

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/size-exemptions.md`:
- Around line 58-59: Update the size metrics in the affected entry of
docs/size-exemptions.md to match the PR objective’s reported reduction from
7,880 to 7,845 lines, replacing the conflicting 7,798 and 14,037 values while
preserving the surrounding ratcheting context.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 57f3e87a-65ff-450f-a0c7-493dd40adeec

📥 Commits

Reviewing files that changed from the base of the PR and between ea88348 and 37ac50a.

📒 Files selected for processing (4)

• docs/size-exemptions.md
• lib/appstate.py
• lib/routers/shop.py
• server.py

[byrongamatos]

The register value 7,798 is correct for the current branch state. This PR was rebased onto #850 (library_extras, which took server.py 7,880 → 7,833); shop's cut then brought it to 7,798 (verified: wc -l server.py = 7798). The '7,845' in the PR description was the pre-rebase number when this branched directly off main — the register (the canonical value) reflects the actual post-rebase file. No code change needed.