Revert 1 main

[j0b333]

What

feedpak surface

• This PR does not change how the app reads/writes feedpaks (manifest keys, pack files, folder layout)
• …or it does, and the spec change landed first via the FEP process — FEP / spec PR: got-feedback/feedpak-spec#___ (once it merges, re-run this PR's checks and the gate goes green)

Checklist

• CHANGELOG.md [Unreleased] updated (user-visible changes)
• Tests added/updated for new behaviour
• Commits are DCO signed off (git commit -s)

Summary by CodeRabbit

• Changes

  • Library scans now always perform a complete directory listing and file-stat check.
  • Manual and background rescans use a simplified scan workflow without a forced mode.
  • Concurrent rescan requests continue to be coalesced into a follow-up scan.

• Tests

  • Removed tests for the retired directory-signature fast-path behavior.
  • Retained coverage for file discovery, uploads, suffix compatibility, and DLC counting.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 876fe858-c39f-4a51-84f2-74e11e002514

📥 Commits

Reviewing files that changed from the base of the PR and between 0b4b174 and c060813.

📒 Files selected for processing (3)

• lib/scan.py
• server.py
• tests/test_feedpak_extension.py

---

📝 Walkthrough

Walkthrough

The scanner no longer supports forced scans or directory-signature fast-path skipping. It always performs the full scan workflow, while rescan endpoints use the simplified API and obsolete fast-path tests are removed.

Changes

Scan flow simplification

Layer / File(s)	Summary
Simplify scanner execution lib/scan.py	Removes directory-signature persistence and fast-path checks, deletes forced-scan state, and retains pending-rescan coalescing.
Update rescan entry points and coverage server.py, tests/test_feedpak_extension.py	Updates both rescan endpoints to call kick_scan() without arguments and removes directory-signature fast-path tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• got-feedBack/feedBack#901: Earlier scanner refactor that introduced the lifecycle and endpoint delegation used here.
• got-feedBack/feedBack#979: Introduced the directory-signature fast path and force support removed by this change.

Suggested reviewers: byrongamatos, chrisbewithyou

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}