This repository was archived by the owner on Sep 21, 2020. It is now read-only.
GPII-3394: Use logfile for logging#1
Merged
Conversation
syslog is not generally available inside a container.
natarajaya
reviewed
Dec 4, 2018
| # Enable logging with logfile as syslog is not generally available inside a container. | ||
| <Plugin "logfile"> | ||
| LogLevel "info" | ||
| File "/var/log/collectd.log" |
There was a problem hiding this comment.
Should this log into stdout/stderr instead? Looks like it is possible using the same logfile plugin.
There was a problem hiding this comment.
+1 for stdout (but I don't have a good understanding of context here)
|
LGTM |
stepanstipl
reviewed
Dec 4, 2018
| # Enable logging with logfile as syslog is not generally available inside a container. | ||
| <Plugin "logfile"> | ||
| LogLevel "info" | ||
| File "/var/log/collectd.log" |
There was a problem hiding this comment.
+1 for stdout (but I don't have a good understanding of context here)
mrtyler
force-pushed
the
gpii-3394-logfile
branch
from
30667d5 to
e26f6df
Compare
Author
|
Using stdout is a good idea. However, I tried it and it didn't work -- no logs in The good news is run-agent.sh tails /var/log/collectd.log, so as-is we do see logs in |
Author
|
Proposed to upstream as wikiwi#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syslog is not generally available inside a container.
This also makes a whitespace-only, documentation-only change that causes the example DaemonSet to break :).
This PR is essentially a bugfix for upstream. I will PR it there after review here.