add support for $ref's in request bodies - #44
Merged
Conversation
|
@Southclaws is attempting to deploy a commit to the lbl-rd Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@Southclaws Cool! I'll take a look in a moment |
Contributor
Author
|
thanks! for now, using the fork actively in https://github.com/Southclaws/rad/pull/1/changes#diff-6939ad63aa2db19c9744bcf201876151af31d4674260edaca29bd679babccf58 against this schema in case it helps validate more use-cases! and now that I think of it, I have a rather mature 13k line schema that could be useful for battle testing this generator here in case it helps! |
Contributor
|
excellent- I'll try that schema too. Testing this pr now should land momentarily |
Contributor
|
nice- that openapi.yaml surfaced a few small things in the client and one larger thing in server generation. Appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for $ref'ing a requestBody
Referenced request bodies are resolved before operation analysis, preserving their requirdness, media type, schema, and validation document, etc..
Generated compatibility
requestBodyis a local$refnow receive the same typed body parameter they would receive if the Request Body Object were inline.Validation
cargo fmt --checkcargo clippy --all-features -- -D warningscargo test --all-featuresscripts/install-smoke.shfor packaging/dependency changes.scripts/spec-compile.shfor generator changes.Notes for reviewers
ai transparency: this was achieved using codex while generating a rust server for a project (radengine)