Skip to content

Fix more instances of arrays in immediate vars#4685

Merged
alan-baker merged 2 commits into
gpuweb:mainfrom
alan-baker:more-immediate-array-fixes
Jul 20, 2026
Merged

Fix more instances of arrays in immediate vars#4685
alan-baker merged 2 commits into
gpuweb:mainfrom
alan-baker:more-immediate-array-fixes

Conversation

@alan-baker

Copy link
Copy Markdown
Contributor
  • Filter invalid variants in required_alignment test

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

* Filter invalid variants in required_alignment test
@alan-baker
alan-baker requested a review from sudonatalie July 20, 2026 13:16
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Results for build job (at 43cd69a):

-webgpu:shader,validation,shader_io,align:required_alignment:* - 36 cases, 1128 subcases (~31/case)
+webgpu:shader,validation,shader_io,align:required_alignment:* - 36 cases, 1116 subcases (~31/case)
-TOTAL: 285244 cases, 2346088 subcases
+TOTAL: 285244 cases, 2346076 subcases

@alan-baker
alan-baker merged commit a5da757 into gpuweb:main Jul 20, 2026
1 check passed
@alan-baker
alan-baker deleted the more-immediate-array-fixes branch July 20, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants