Skip to content

Fix buffer_view validation tests#4686

Merged
alan-baker merged 1 commit into
gpuweb:mainfrom
alan-baker:fix-buffer-view-tests
Jul 21, 2026
Merged

Fix buffer_view validation tests#4686
alan-baker merged 1 commit into
gpuweb:mainfrom
alan-baker:fix-buffer-view-tests

Conversation

@alan-baker

Copy link
Copy Markdown
Contributor
  • bufferView and bufferArrayView tests had invalid checks for the parameter type tests (copypasta)

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

* bufferView and bufferArrayView tests had invalid checks for the
  parameter type tests (copypasta)
@alan-baker
alan-baker requested review from dj2 and sudonatalie July 21, 2026 16:55
@github-actions

Copy link
Copy Markdown

Results for build job (at e0eead0):

 Test case/subcase counts did not change.

@alan-baker
alan-baker merged commit 499044a into gpuweb:main Jul 21, 2026
1 check passed
copybara-service Bot pushed a commit to google/dawn that referenced this pull request Jul 22, 2026
* CTS fixes from gpuweb/cts#4686 landed

Change-Id: I0b9c1659b9835d8340d67635cce7dfa89d226172
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/326515
Reviewed-by: Natalie Chouinard <chouinard@google.com>
Commit-Queue: Natalie Chouinard <chouinard@google.com>
Auto-Submit: Alan Baker <alanbaker@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants