feat: fix hive rpc_compat test suite failures#112
Open
SoarinSkySagar wants to merge 2 commits into
Open
Conversation
SoarinSkySagar
marked this pull request as ready for review
July 16, 2026 18:07
Author
|
part of #113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIPPrior to this PR, the client was failing the
finalized block pairs with finalized statetest fromrpc-compatsuite on hive. The problem was that the test was calling/lean/v0/blocks/finalizedendpoint to check if the the finalized signed block matches the expected signed block, but the client did not have the endpoint itself so the test was failing.This PR adds the endpoint with correct functionality and the corresponding tests (tests are Claude generated). I have tested the client with the entire
rpc_compatsuite and all tests are passing now.The passing test:
