Skip to content

Fix indexing.rst doc-example failures - #1850

Open
vaimdevs wants to merge 1 commit into
fix/site-wide-org-dataset-errorfrom
fix/indexing-rst-examples
Open

Fix indexing.rst doc-example failures#1850
vaimdevs wants to merge 1 commit into
fix/site-wide-org-dataset-errorfrom
fix/indexing-rst-examples

Conversation

@vaimdevs

@vaimdevs vaimdevs commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
##Fix
* Fix indexing.rst doc-example failure — define new_edges_df before use in the invalidation example (was raising NameError).

Mark the intro teaser block as doc-test:skip (pseudocode, g undefined
at that point) and define new_edges_df in the invalidation example so
it actually runs instead of raising NameError.
@lmeyerov
lmeyerov changed the base branch from fix/site-wide-org-dataset-error to master August 18, 2026 18:46
@lmeyerov
lmeyerov changed the base branch from master to fix/site-wide-org-dataset-error August 18, 2026 18:47
lmeyerov added a commit that referenced this pull request Aug 18, 2026
docs(gfql): fix indexing.rst doc-example NameError (cherry-pick of #1850)
@lmeyerov

Copy link
Copy Markdown
Contributor

Your fix landed on master via #1933 (cherry-pick of 4e7654bce, authorship preserved) so it didn't have to wait behind #1721's review — this PR will show as resolved/empty once #1721 merges master forward. Thanks for catching the NameError; verified the amount column exists in the page's own edges_df and that assign returning a new frame is exactly the invalidation lesson the example teaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants