feat: Simplify driver version migration through magento-version file#4410
Closed
joannalauu wants to merge 4 commits into
Closed
feat: Simplify driver version migration through magento-version file#4410joannalauu wants to merge 4 commits into
magento-version file#4410joannalauu wants to merge 4 commits into
Conversation
- Requests user input for Magento version during schematic generation - Generates `magento-version` file with commerce schematic - Update magento v2.4.1 & v2.4.2 to use providers, depreciating modules - Update demo app to use `magento-version` file
joannalauu
commented
Apr 5, 2026
| import { DaffShopifyExternalRouterDriver } from '@daffodil/external-router/driver/shopify'; | ||
|
|
||
| import { FakeExternalRouterService } from './fake'; | ||
| import { DaffExternalRouterMagentoDriver } from '../../../drivers/magento-version'; |
Contributor
Author
There was a problem hiding this comment.
not ideal - thinking of better solution
griest024
reviewed
Apr 6, 2026
| @@ -0,0 +1,4 @@ | |||
| // To use a different Magento API version, change the import paths below. | |||
| // Supported versions: 2.4.1, 2.4.2, 2.4.3 | |||
| export { provideDaffExternalRouterMagentoDriver } from '@daffodil/external-router/driver/magento/2.4.3'; | |||
Member
There was a problem hiding this comment.
We're hoping to avoid having the app dev responsible for changing a list of imports. Were you unable to get tree shaking to work with the imports?
Contributor
Author
|
Closed in favor of #4424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #3137
Part of: #
New behavior
Supports defining a
magento-versionfile that exportsprovideDaffExternalRouterMagentoDriverandDaffExternalRouterMagentoDriverfrom the desired magento driver version. Application usage ofprovideDaffExternalRouterMagentoDriverandDaffExternalRouterMagentoDriverwill import frommagento-version. This allows all version updates to be centralized in one file.Additional changes:
magento-versionfile with commerce schematicmagento-versionfileBreaking change?
Additional context