fix: add missing key fields to graphql fragments and queries#4491
Open
griest024 wants to merge 1 commit into
Open
fix: add missing key fields to graphql fragments and queries#4491griest024 wants to merge 1 commit into
griest024 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #
Part of: #
New behavior
Breaking change?
Additional context
I used an eslint plugin (that's not quite ready to merge but does work) to auto add these. The one caveat is that the plugin cannot tell if a key field is added by a fragment or not so it adds them to basically all queries. Should be okay since they will just get merged by apollo and its better safe than sorry