Skip to content

New Font Awesome 7 Pro icons theme#2267

Merged
ammgws merged 1 commit into
greshake:masterfrom
GreyXor:feat-new-fa7-pro-theme
May 22, 2026
Merged

New Font Awesome 7 Pro icons theme#2267
ammgws merged 1 commit into
greshake:masterfrom
GreyXor:feat-new-fa7-pro-theme

Conversation

@GreyXor
Copy link
Copy Markdown
Contributor

@GreyXor GreyXor commented Apr 21, 2026

Hello,

This is a new Font Awesome 7 Pro icon theme that allows us to use icons from the Pro collection.

The set may include icons from both the Free and Pro collections. It’s still a work in progress, as I’m continuing to expand it with additional icons, particularly from the Pro collection, which offers improved visual options compared to the Free set.

For each completed icon, you’ll find its Font Awesome URL included in the comments, giving you a sense of the current progress.

Context: #2263 (comment)

@GreyXor GreyXor marked this pull request as ready for review April 23, 2026 08:17
Copy link
Copy Markdown
Contributor Author

@GreyXor GreyXor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, "slash" is better for "no battery" as "exclamation" is more for "problem with battery"

Comment thread files/icons/awesome7pro.toml Outdated
@GreyXor
Copy link
Copy Markdown
Contributor Author

GreyXor commented Apr 23, 2026

Re-added all icons and used better icons more adequate from "pro".

@GreyXor
Copy link
Copy Markdown
Contributor Author

GreyXor commented Apr 23, 2026

Hello @bim9262,

Can I directly use UTF-8 glyphs in TOML strings, similar to the emoji icon set, instead of using escape sequences like \u...? I already tested, it works as expected

For example:

refresh = ""
resolution = ""
scratchpad = ""

instead of:

refresh = "\uf021"
resolution = "\ue278"
scratchpad = "\uf2d2"

This approach would make it easier for users who have the appropriate font installed to immediately recognize the icons, and it avoids the need to include comments describing each glyph.

image image

@bim9262
Copy link
Copy Markdown
Collaborator

bim9262 commented Apr 24, 2026

I'd recommend not using the icons instead of the utf-8 codes.
This makes it much more difficult for somebody without the fonts to verify the icons as well as being really annoying when working on multiple themes as you'd have to set your font for each file you're reviewing.

@GreyXor GreyXor force-pushed the feat-new-fa7-pro-theme branch from f9d325b to 5aea108 Compare April 25, 2026 07:17
@GreyXor
Copy link
Copy Markdown
Contributor Author

GreyXor commented Apr 25, 2026

I'd recommend not using the icons instead of the utf-8 codes. This makes it much more difficult for somebody without the fonts to verify the icons as well as being really annoying when working on multiple themes as you'd have to set your font for each file you're reviewing.

Thanks for your input! I reverted the utf-8 codes

@GreyXor
Copy link
Copy Markdown
Contributor Author

GreyXor commented May 21, 2026

Hi @bim9262,
Do we need anything else for the merge? Thanks!
FYI, I've been using this font theme myself for a month.

@ammgws
Copy link
Copy Markdown
Collaborator

ammgws commented May 22, 2026

Add to docs and we are all set
I.e.
https://github.com/greshake/i3status-rust/blob/master/doc/themes.md#available-icon-sets

Squash into one commit please

@GreyXor GreyXor force-pushed the feat-new-fa7-pro-theme branch from d402198 to 8d5690e Compare May 22, 2026 09:23
@GreyXor
Copy link
Copy Markdown
Contributor Author

GreyXor commented May 22, 2026

Add to docs and we are all set I.e. https://github.com/greshake/i3status-rust/blob/master/doc/themes.md#available-icon-sets

Squash into one commit please

Thanks, done!

@ammgws ammgws merged commit 1fa5e72 into greshake:master May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants