docs: fix Intel GPU Usage in examples/README.md#2272
Merged
Conversation
Collaborator
|
Has the |
Contributor
Author
|
To be precise, the The |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for Intel GPU usage parses the Render/3D value from the 8th field of
intel_gpu_top -loutput. Since this was introduced, the Render/3D field has shifted to the 9th position, breaking the example:oleh@gentoooleh ~ $ sudo intel_gpu_top -l -n 1 Freq MHz IRQ RC6 Power W IMC MiB/s RCS BCS VCS VECS req act /s % gpu pkg rd wr % se wa % se wa % se wa % se wa 388 388 582 50 0.95 36.54 3436 2309 42.43 0 0 0.00 0 0 0.00 0 0 0.00 0 0To prevent future field position shifts, I propose to utilize JSON output from
intel_gpu_top -Jand extract the Render/3D value by key withjq:[1].engines["Render/3D"].busy.Note: the first sample in the JSON array always contains a high Render/3D spike, so the second sample (
[1]) is used instead to get an accurate numbers. I also added this note to the file.