Add optional interpolation for thermosphere space-weather indices - #441
Draft
Z3rmy wants to merge 4 commits into
Draft
Add optional interpolation for thermosphere space-weather indices#441Z3rmy wants to merge 4 commits into
Z3rmy wants to merge 4 commits into
Conversation
Add the opt-in configuration field for JB2008. The default remains false, preserving the existing preceding-epoch behavior.
Added option to interpolate space weather indices in the ThermosphereNRLMSIS2 class.
Removed unnecessary comments and documentation from thermosphereNRLMSIS2.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the optional
interpolateSpaceWeatherIndicesBoolean configuration field to the existing JB2008 and NRLMSIS 2.0 thermosphere models.false, preserving the existing preceding-input-epoch behavior.Scope
This PR intentionally contains only the two existing thermosphere source headers. It excludes generated schema/documentation files, example data, and DTM models.
Validation
groops-devs/groops:main.thermosphereJB2008.handthermosphereNRLMSIS2.hare changed.