Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
ab97045
SynchronizationContextTest changes for scheduleFixedDelay with Duration
SreeramdasLavanya Sep 20, 2024
fef4c92
Revert "SynchronizationContextTest changes for scheduleFixedDelay wit…
SreeramdasLavanya Sep 20, 2024
778cfb4
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 23, 2024
328bcbf
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 24, 2024
6a66054
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 26, 2024
4113845
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 1, 2024
09c3509
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 8, 2024
62a88ec
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 9, 2024
f658685
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 11, 2024
c51a5e4
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 15, 2024
02e92c5
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 17, 2024
4c31880
api: Javadoc changes for LoadBalancer method signatures
SreeramdasLavanya Oct 17, 2024
9ddcb09
api: Changes for UNAVAILABLE to Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
596d11d
api: Check style fix for UNAVAILABLE to Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
d9bf85e
api: Check style fix for Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
401a7d2
api: Check style fix for Status.UNAVAILABLE
SreeramdasLavanya Oct 21, 2024
f388ac2
api: Check style fix for Status.UNAVAILABLE
SreeramdasLavanya Oct 21, 2024
6e4efc7
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 25, 2024
cb315f0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 25, 2024
18b74c0
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 28, 2024
380345c
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 28, 2024
846eb00
api/util/services: Deprected handleResolvedAddresses method and relat…
SreeramdasLavanya Oct 28, 2024
ee36c4e
interop-testing: Changes for deprecated handleResolvedAddresses metho…
SreeramdasLavanya Oct 29, 2024
b1f857f
xds: Changes for deprecated handleResolvedAddresses method and relate…
SreeramdasLavanya Oct 29, 2024
d236b88
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 30, 2024
891b547
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 30, 2024
6d3abf0
api: Reverted changes for LoadBalancer and LoadBalancerTest
SreeramdasLavanya Nov 4, 2024
ca3e613
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 4, 2024
f9ffbc6
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 4, 2024
47002fe
util: Replaced handleResolvedAddress to acceptResolvedAddresses.
SreeramdasLavanya Nov 4, 2024
cb85563
api: Reverted back to acceptResolvedAddress
SreeramdasLavanya Nov 5, 2024
b44e402
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 6, 2024
8bfedb0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 6, 2024
b9cced0
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 7, 2024
66a3495
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 7, 2024
45d3c75
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 8, 2024
b67b7ab
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 12, 2024
1b0ddaa
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 14, 2024
cfaab92
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 18, 2024
a0e5bf2
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 19, 2024
35f0769
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 22, 2024
bddc31c
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 25, 2024
b9a49a0
Merge branch 'master' into FixIssue-11194
SreeramdasLavanya Nov 25, 2024
1e6fef9
api/util: Addressed the re-review points
SreeramdasLavanya Nov 25, 2024
1674b6d
api/util: Resolved Deprecation warnings
SreeramdasLavanya Nov 25, 2024
60b4a39
api/util: Resolved checkstyle issues
SreeramdasLavanya Nov 25, 2024
8b02cd4
api/util: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
5ece923
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 26, 2024
d746ef8
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 26, 2024
516e75b
util/xds: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
36ecadb
util: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
aa43806
Merge branch 'grpc:master' into master
SreeramdasLavanya Dec 3, 2024
d756690
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 3, 2024
d2e6f04
util: Included suppress warnings for updateChildrenWithResolvedAddres…
SreeramdasLavanya Dec 3, 2024
2ab1ae2
Merge branch 'grpc:master' into master
SreeramdasLavanya Dec 9, 2024
4a690a2
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 9, 2024
f66c084
Merge branch 'grpc:master' into master
SreeramdasLavanya Dec 10, 2024
8c75ed0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 10, 2024
60932d8
Merge branch 'grpc:master' into master
SreeramdasLavanya Jan 20, 2025
4b542f7
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Jan 20, 2025
9fc5391
Merge branch 'grpc:master' into master
SreeramdasLavanya Feb 20, 2025
af00e50
Merge branch 'master' into FixIssue-11194
SreeramdasLavanya Feb 20, 2025
ea42960
util: Changed deprecated method to newly added method
SreeramdasLavanya Feb 20, 2025
226301c
util: Removed delegate for acceptResolved method
SreeramdasLavanya Feb 20, 2025
e6bea7f
util: Removed override annotation
SreeramdasLavanya Feb 20, 2025
fd5263f
Merge branch 'grpc:master' into master
SreeramdasLavanya Mar 4, 2025
67c504f
Merge branch 'master' into FixIssue-11194
SreeramdasLavanya Mar 4, 2025
29fd776
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Mar 6, 2025
4300013
util: included surpresswarning annotation to fix Inlineable issue
SreeramdasLavanya Mar 6, 2025
536311d
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Mar 7, 2025
1ada412
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Mar 11, 2025
9a63a50
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya May 6, 2025
c1122d4
Merge branch 'master' of https://github.com/grpc/grpc-java into FixIs…
shivaspeaks Mar 16, 2026
2b16da6
address comments
shivaspeaks Mar 16, 2026
b60e494
use acceptResolvedAddresses in ClusterImplLoadBalancer
shivaspeaks Mar 16, 2026
1b87c80
Remove useless docs added to GracefluwSwitchLb
ejona86 Mar 23, 2026
6ed0674
Mark forwarding implementation deprecated instead of deleting
ejona86 Mar 23, 2026
e44ca7d
Delete random formatting change to file
ejona86 Mar 23, 2026
66e17cf
Tweak doc tweaks
ejona86 Mar 23, 2026
361c4b8
Don't implement ForwardingLb.acceptResolvedAddresses()
ejona86 Mar 23, 2026
6edec88
Fix missed doc mentioning UNAVAILABLE
ejona86 Mar 23, 2026
97cecbf
Restore removed Override annotation
ejona86 Mar 23, 2026
9e52edb
Remove useless doc
ejona86 Mar 23, 2026
059f1cd
The test was for the old implementation
ejona86 Mar 23, 2026
98212ce
deprecate canHandleEmptyAddressListFromNameResolution
shivaspeaks Mar 24, 2026
93ef6f9
Merge branch 'FixIssue-11194' of https://github.com/SreeramdasLavanya…
shivaspeaks Mar 24, 2026
d8f20dd
Fix style; more precise language
ejona86 Mar 24, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions api/src/main/java/io/grpc/LoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,16 @@ public String toString() {
private int recursionCount;

/**
* Handles newly resolved server groups and metadata attributes from name resolution system.
* {@code servers} contained in {@link EquivalentAddressGroup} should be considered equivalent
* but may be flattened into a single list if needed.
*
* <p>Implementations should not modify the given {@code servers}.
* Handles newly resolved addresses and metadata attributes from name resolution system.
* Addresses in {@link EquivalentAddressGroup} should be considered equivalent but may be
* flattened into a single list if needed.
*
* @param resolvedAddresses the resolved server addresses, attributes, and config.
* @since 1.21.0
*
* @deprecated Use instead {@link #acceptResolvedAddresses(ResolvedAddresses)}
*/
@Deprecated
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
if (recursionCount++ == 0) {
// Note that the information about the addresses actually being accepted will be lost
Expand All @@ -179,12 +180,10 @@ public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
* EquivalentAddressGroup} addresses should be considered equivalent but may be flattened into a
* single list if needed.
*
* <p>Implementations can choose to reject the given addresses by returning {@code false}.
*
* <p>Implementations should not modify the given {@code addresses}.
* @param resolvedAddresses the resolved server addresses, attributes, and config
* @return {@code Status.OK} if the resolved addresses were accepted, otherwise an error to report
* to the name resolver
*
* @param resolvedAddresses the resolved server addresses, attributes, and config.
* @return {@code true} if the resolved addresses were accepted. {@code false} if rejected.
* @since 1.49.0
*/
public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) {
Expand Down Expand Up @@ -418,7 +417,16 @@ public void handleSubchannelState(
*
* <p>This method should always return a constant value. It's not specified when this will be
* called.
*
* <p>Note that this method is only called when implementing {@code handleResolvedAddresses()}
* instead of {@code acceptResolvedAddresses()}.
*
* @deprecated Instead of overwriting this and {@code handleResolvedAddresses()}, only
* overwrite {@code acceptResolvedAddresses()} which indicates if the addresses provided
* by the name resolver are acceptable with the {@code boolean} return value.
*/
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public boolean canHandleEmptyAddressListFromNameResolution() {
return false;
}
Expand Down
2 changes: 2 additions & 0 deletions grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ public void handleNameResolutionError(Status error) {
}

@Override
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public boolean canHandleEmptyAddressListFromNameResolution() {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ protected LoadBalancer delegate() {
return delegateLb;
}

@Deprecated
@Override
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
helper.setRpcBehavior(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public void parseInvalidConfig() {
assertThat(status.getDescription()).contains("rpcBehavior");
}

@Deprecated
@Test
public void handleResolvedAddressesDelegated() {
RpcBehaviorLoadBalancer lb = new RpcBehaviorLoadBalancer(new RpcBehaviorHelper(mockHelper),
Expand Down
3 changes: 3 additions & 0 deletions util/src/main/java/io/grpc/util/ForwardingLoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public abstract class ForwardingLoadBalancer extends LoadBalancer {
*/
protected abstract LoadBalancer delegate();

@Deprecated
@Override
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
delegate().handleResolvedAddresses(resolvedAddresses);
Expand All @@ -52,6 +53,8 @@ public void shutdown() {
}

@Override
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public boolean canHandleEmptyAddressListFromNameResolution() {
return delegate().canHandleEmptyAddressListFromNameResolution();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public GracefulSwitchLoadBalancer(Helper helper) {
this.helper = checkNotNull(helper, "helper");
}

@Deprecated
@Override
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
Config config = (Config) resolvedAddresses.getLoadBalancingPolicyConfig();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ public void handleSubchannelState_shouldThrow() {
}

@Test
@Deprecated
public void canHandleEmptyAddressListFromNameResolutionForwardedToLatestPolicy() {
assertIsOk(gracefulSwitchLb.acceptResolvedAddresses(addressesBuilder()
.setLoadBalancingPolicyConfig(createConfig(lbPolicies[0], new Object()))
Expand Down Expand Up @@ -136,6 +137,7 @@ public void canHandleEmptyAddressListFromNameResolutionForwardedToLatestPolicy()
assertThat(gracefulSwitchLb.canHandleEmptyAddressListFromNameResolution()).isTrue();
}

@Deprecated
@Test
public void handleResolvedAddressesAndNameResolutionErrorForwardedToLatestPolicy() {
ResolvedAddresses addresses = newFakeAddresses();
Expand Down
3 changes: 1 addition & 2 deletions xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,13 @@ public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) {
childLbHelper.updateFilterMetadata(config.filterMetadata);
childLbHelper.updateBackendMetricPropagation(config.backendMetricPropagation);

childSwitchLb.handleResolvedAddresses(
return childSwitchLb.acceptResolvedAddresses(
resolvedAddresses.toBuilder()
.setAttributes(attributes.toBuilder()
.set(NameResolver.ATTR_BACKEND_SERVICE, cluster)
.build())
.setLoadBalancingPolicyConfig(config.childConfig)
.build());
return Status.OK;
}

@Override
Expand Down
2 changes: 2 additions & 0 deletions xds/src/main/java/io/grpc/xds/WeightedTargetLoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ public void handleNameResolutionError(Status error) {
}

@Override
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public boolean canHandleEmptyAddressListFromNameResolution() {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ protected LoadBalancer delegate() {
return delegateLb;
}

@Deprecated
@Override
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
MetadataLoadBalancerConfig config
Expand Down
Loading