xds: Handle empty target URI authorities the same as null.#12728
Open
jdcormie wants to merge 3 commits intogrpc:masterfrom
Open
xds: Handle empty target URI authorities the same as null.#12728jdcormie wants to merge 3 commits intogrpc:masterfrom
jdcormie wants to merge 3 commits intogrpc:masterfrom
Conversation
Fixes an oversight in grpc#12660. io.grpc.Uri#getAuthority makes a distinction between xds:///service and xds:/service but java.net.URI does not. XdsNameResolver wants to treat those two cases the same.
ejona86
approved these changes
Mar 24, 2026
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I'm sorta surprised that checkstyle doesn't complain about having only some params documented in javadoc. But I see what you did, and it seems fair.
jdcormie
force-pushed
the
grpc-uri-xds-2
branch
from
53f5b22 to
bc5db7c
Compare
ejona86
reviewed
Mar 25, 2026
jdcormie
force-pushed
the
grpc-uri-xds-2
branch
from
bc5db7c to
c6cb102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in #12660 where io.grpc.Uri#getAuthority makes a distinction between xds:///service and xds:/service that java.net.URI never did. XdsNameResolver wants to treat those two "no authority" cases the same but now it must do that for itself.