core: Implement load balancing policy delay plumbing#12807
Draft
AgraVator wants to merge 1 commit into
Draft
Conversation
This commit implements the plumbing required to propagate delay reason tokens from load balancing policies up to the transport layer and tracers, as specified in the LB policy delay design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the plumbing required to propagate delay reason tokens from load balancing policies up to the transport layer and tracers, as specified in the LB policy delay design.
What changed
delayReasonTokentoPickResultand factory methodwithNoResult(String).delayStarted(String)anddelayEnded()hooks toClientStreamTracerto track delay segments.DelayedClientTransportto track delay tokens inPendingStreamand notify tracers when delays start, change, or end.PickFirstandRoundRobinpolicies to emit cached tokens when connecting.RingHash,RLS, andCDSpolicies to emit specific delay tokens when buffering picks.PriorityLoadBalancerto wrap child pickers and prependpriority_X:to child tokens to track failovers.Tests
DelayedClientTransportTestfor token propagation and cancellation.PickFirst,RoundRobin,RingHash, andRLS.CdsLoadBalancer2Testforcds:discovery_pendingstate.RingHashLoadBalancerTestto verify pass-through behavior of child tokens.PriorityLoadBalancerTestto verify token prefixing.Notes