Add nice!nano v2 board support - #100
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesArrr, this adds complete nice!nano v2 support: board and variant definitions, UF2 conversion from Intel HEX, upload configuration, bootloader options, and documentation for UF2 programming. nice!nano v2 hardware variant
UF2 export and board integration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ArduinoBuild
participant uf2conv.py
participant UF2Bootloader
participant nice_nano_v2
ArduinoBuild->>uf2conv.py: Convert Intel HEX with family ID
uf2conv.py-->>ArduinoBuild: Produce UF2 image
ArduinoBuild->>UF2Bootloader: Copy UF2 image
UF2Bootloader->>nice_nano_v2: Program firmware
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 127-131: Expand the “Uploading via UF2” section with the exact IDE
action used to export the .uf2 file, then document how to reset the board into
its UF2 bootloader, including the required reset-button or reset-sequence steps
before copying the file to the mounted drive.
In `@tools/uf2conv.py`:
- Around line 31-44: The HEX parser must reject type-specific structural errors
and trailing data after EOF. Update the record parser function containing the
length/checksum validation to enforce required payload lengths and addresses for
each supported record type, including a valid zero-length EOF record; then
update the main record-processing loop to require exactly one EOF, reject any
non-empty records after it, and fail when EOF is missing instead of silently
stopping.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 25c5a43d-dd9f-43bc-9d38-7c74a46489f6
📒 Files selected for processing (6)
README.mdboards.txtplatform.txttools/uf2conv.pyvariants/nice_nano_v2/variant.cppvariants/nice_nano_v2/variant.h
|
I test on Arm(Nim)BLE Boards 4.0. Work well on BLE Scan example. |
|
Thanks! Sorry I didn't see this sooner, will review later today. |
|
Kk, love this lib! |
Validation passed:
Summary by CodeRabbit
New Features
Documentation